Skip to content

Add dtos and other classes for task #2446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 92 commits into from
Feb 13, 2025
Merged

Conversation

inv-jishnu
Copy link
Contributor

@inv-jishnu inv-jishnu commented Jan 2, 2025

Description

In this PR, I have added a few class and dtos for import task. This includes classes for validation and mapping of import data and a class which has message constants used in tasks.
And this also includes the import options class and log mode enum class

Related issues and/or PRs

Please review and merge this PR once the following PR is merged

Changes made

Added dtos and other classes for task.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

Road map to merge remaining data loader core files. Current status

Release notes

N/A

@ypeckstadt ypeckstadt marked this pull request as ready for review February 10, 2025 07:20
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;

public class ImportDataMappingTest {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test classes can be package-private in JUnit 5.

@inv-jishnu inv-jishnu requested a review from komamitsu February 12, 2025 05:15
Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@Torch3333 Torch3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@inv-jishnu
Copy link
Contributor Author

inv-jishnu commented Feb 13, 2025

@komamitsu san, @brfrn169 san, @Torch3333 san,

The commit 6d8ecf3 is to make error code id's consistent (id 174 was missing so I updated the id's of error messages that added in this PR to make the id's consistent). Just noticed it while trying to check the error codes in other PRs.

@ypeckstadt ypeckstadt merged commit 067b8ba into master Feb 13, 2025
48 checks passed
@ypeckstadt ypeckstadt deleted the feat/data-loader/import-task branch February 13, 2025 08:00
feeblefakie pushed a commit that referenced this pull request Feb 13, 2025
feeblefakie pushed a commit that referenced this pull request Feb 13, 2025
feeblefakie pushed a commit that referenced this pull request Feb 13, 2025
feeblefakie pushed a commit that referenced this pull request Feb 13, 2025
feeblefakie pushed a commit that referenced this pull request Feb 13, 2025
@inv-jishnu inv-jishnu mentioned this pull request Apr 11, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants