-
Notifications
You must be signed in to change notification settings - Fork 38
Add dtos and other classes for task #2446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
import org.junit.jupiter.api.BeforeEach; | ||
import org.junit.jupiter.api.Test; | ||
|
||
public class ImportDataMappingTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit test classes can be package-private in JUnit 5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
@komamitsu san, @brfrn169 san, @Torch3333 san, The commit 6d8ecf3 is to make error code id's consistent (id 174 was missing so I updated the id's of error messages that added in this PR to make the id's consistent). Just noticed it while trying to check the error codes in other PRs. |
Co-authored-by: Peckstadt Yves <[email protected]>
Co-authored-by: Peckstadt Yves <[email protected]>
Co-authored-by: Peckstadt Yves <[email protected]>
Co-authored-by: Peckstadt Yves <[email protected]>
Co-authored-by: Peckstadt Yves <[email protected]>
Description
In this PR, I have added a few class and dtos for import task. This includes classes for validation and mapping of import data and a class which has message constants used in tasks.
And this also includes the import options class and log mode enum class
Related issues and/or PRs
Please review and merge this PR once the following PR is merged
Changes made
Added dtos and other classes for task.
Checklist
Additional notes (optional)
Road map to merge remaining data loader core files. Current status
General
Export
Import
Release notes
N/A